SvgXml compatibility with ReAnimated - [Help Needed] #1444
+67
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our app leverages in combination with
babel-plugin-inline-import
for our Iconography. The Issue we've run into is that we're not able to use Reanimated with the fill property in order to animated icon color changes.I've gotten the solution to work on iOS but I'm having no luck on Android. It'd be awesome if someone with Android knowledge be able to chip in.
The iOS solution was fairly straightforward.
setNativeProps
function I split the props into two groups; those pertaining to the root element and those pertaining to the child element.Test Plan
I tested the changes using our organizations app. I was successful on iOS while Android does not show the icon at all.
Compatibility
Checklist
README.md
__tests__
folder