feat: invalidate on color change (#2470)

# Summary Invalidate element when `color` prop changes.
software-mansion · Oct 2, 2024 · f1d33a4 · f1d33a4
1 parent b4dc975
commit f1d33a4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/apple/RNSVGRenderable.h b/apple/RNSVGRenderable.h
@@ -35,6 +35,8 @@
 @property (nonatomic, assign) CGPathRef hitArea;
 @property (nonatomic, strong) NSString *filter;
 
+- (void)setColor:(RNSVGColor *)color;
+
 - (void)setHitArea:(CGPathRef)path;
 
 - (NSArray<NSString *> *)getAttributeList;

diff --git a/apple/RNSVGRenderable.mm b/apple/RNSVGRenderable.mm
@@ -59,6 +59,15 @@ - (void)invalidate
   self.dirty = true;
 }
 
+- (void)setColor:(RNSVGColor *)color
+{
+  if (color == self.tintColor) {
+    return;
+  }
+  [self invalidate];
+  self.tintColor = color;
+}
+
 - (void)setFill:(RNSVGBrush *)fill
 {
   if (fill == _fill) {

diff --git a/apple/Utils/RNSVGFabricConversions.h b/apple/Utils/RNSVGFabricConversions.h
@@ -141,7 +141,7 @@ void setCommonRenderableProps(const T &renderableProps, RNSVGRenderable *rendera
 {
   setCommonNodeProps(renderableProps, renderableNode);
   if (RCTUIColorFromSharedColor(renderableProps.color)) {
-    renderableNode.tintColor = RCTUIColorFromSharedColor(renderableProps.color);
+    [renderableNode setColor:RCTUIColorFromSharedColor(renderableProps.color)];
   }
   renderableNode.fill = brushFromColorStruct(renderableProps.fill);
   renderableNode.fillOpacity = renderableProps.fillOpacity;