Add unhandled exception to TabNavigatorObserver catch block #6902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szydlovsky
force-pushed
the
@szydlovsky/fix-unhandled-java-excption
branch
from
ae8b7a8 to
5732a49
Compare
|
Do we know which line of code exactly causes On the other hand, if this works (and also handles other types of exceptions) then maybe we shouldn't waste more time on debugging that and simply shift the PR in its current form. |
|
@tomekzaw exactly my sentiment. I'd rather not meddle in the code risking getting something broken if a simple exception handling is enough |
|
Update: got community confirmation that it fixes the issue: #6724 (comment) |
tomekzaw
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6724
Turns out that
TabNavigatorObserver'sonFragmentUpdatedidn't handleNullPointerException, which in turn sometimes crashed release builds on android.Test plan
I wasn't able to create a simple reproduction but I have at least one SWM project that used the exact same code to patch Reanimated and it took care of their android crashes.