Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assert ReanimatedModule is loaded before initializing UI runtime #6835

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: assert ReanimatedModule is loaded before initializing UI runtime #6835

merged 1 commit into from
Dec 20, 2024

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Dec 19, 2024

Summary

initializeUIRuntime gets called in top level, therefore the JS engine may decide to execute it before ReanimatedModule is resolved, which is generally bad. This fixes that.

Test plan

See CounterExample before and after.

@tjzel tjzel requested a review from piaskowyk December 19, 2024 14:03
@tjzel tjzel added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 7e40230 Dec 20, 2024
10 checks passed
@tjzel tjzel deleted the @tjzel/enforce-rea-module-load-before-init branch December 20, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjzel @piaskowyk