Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inject IS_FABRIC from worklets #6833

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: inject IS_FABRIC from worklets #6833

merged 1 commit into from
Dec 20, 2024
+7 −7

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Dec 19, 2024

Summary

We need to inject it from the Decorator that executes sooner.

Test plan

Example App doesn't throw errors anymore on bare BokehExample

@tjzel tjzel requested a review from tomekzaw December 19, 2024 12:19
tomekzaw
tomekzaw approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@tomekzaw tomekzaw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can approve that but sounds like _IS_FABRIC is a Reanimated-specific concept and Worklets don't need to know the architecture. Is there a better way to fix this?

@tjzel
Copy link
Collaborator Author

tjzel commented Dec 19, 2024

@tomekzaw #6836 refactors this bit of code, this PR is only a bandaid for now

@tomekzaw
Copy link
Member

Okay, thanks for explanation

@tomekzaw tomekzaw added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit e60e35b Dec 20, 2024
18 checks passed
@tomekzaw tomekzaw deleted the @tjzel/is-fabric-injection-fix branch December 20, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

@tomekzaw tomekzaw tomekzaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjzel @tomekzaw @piaskowyk