refactor: restructure worklets source sets #6813
Open
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
force-pushed
the
@tjzel/worklets/restructure-worklets-source-sets
branch
from
787f2e0 to
7cffa8f
Compare
tjzel
force-pushed
the
@tjzel/worklets/external-worklets-example
branch
from
61b9e49 to
7ad15d2
Compare
tjzel
force-pushed
the
@tjzel/worklets/restructure-worklets-source-sets
branch
from
7cffa8f to
b30c495
Compare
piaskowyk
reviewed
Jan 2, 2025
| @@ -347,9 +347,19 @@ android { | |||
| } | |||
| sourceSets.main { | |||
| java { | |||
| // Always present | |||
| srcDirs += "src/worklets/WorkletsModule/java" | |||
There was a problem hiding this comment.
Why do we always do that? Is this just a temporary workaround or a permanent solution?
There was a problem hiding this comment.
I'm doing it to have a clear separation of Worklets and Reanimated in the file structure within react-native-reanimated so the "code duplication" trick would be simpler and more transparent. These exact files are necessary because Reanimated declares WorkletsModule in TypeScript and it can't be missing.
tjzel
force-pushed
the
@tjzel/worklets/restructure-worklets-source-sets
branch
from
b30c495 to
2634199
Compare
tjzel
changed the base branch from
@tjzel/worklets/external-worklets-example
to
@tjzel/worklets/linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To use
react-native-workletsdynamically we must have a convenient way of disabling Worklets code that's inside Reanimated. Therefore we need to adjust Worklets' Java file locations.Test plan
CI