Fix keyframe types #6438
Merged
Fix keyframe types #6438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
reviewed
Aug 23, 2024
packages/react-native-reanimated/src/layoutReanimation/animationBuilder/commonTypes.ts
Show resolved
Hide resolved
packages/react-native-reanimated/src/layoutReanimation/animationBuilder/Keyframe.ts
Outdated
Show resolved
Hide resolved
tjzel
approved these changes
Aug 26, 2024
tjzel
reviewed
Aug 30, 2024
packages/react-native-reanimated/src/layoutReanimation/animationBuilder/Keyframe.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomasz Żelawski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this PR is to ban incorrect definitions of keyframe animations:
const keyframeAnimation = new Keyframe({ ! 0: { opacity: 0 }, ! from: { opacity: 0 }, 50: { opacity: 0.5 }, 100: { opacity: 1 }, })const keyframeAnimation = new Keyframe({ 0: { opacity: 0, ! easing: Easing.exp, }, 50: { opacity: 0.5 }, 100: { opacity: 1 }, })const keyframeAnimation = new Keyframe({ 0: { opacity: 0 }, 50: { opacity: 0.5 }, ! 100: { opacity: 1 }, ! to: { opacity: 0 }, })Test plan
Tested on example on runtime tests
Documentation update
Added a remark, how to use easing and updated types.