Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about nested <Text> components #1510

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Conversation

piaskowyk
Copy link
Member

@piaskowyk piaskowyk commented Dec 7, 2020

Description

I added to documentation information about the impossibility of animating a virtual component.
For example we can’t animate nested <Text> components because React Native change

<Text>
   string1
   <Text>string2</Text>
</Text>

to

<RCTTextView>
   string1
   <RCTVirtualText>string2</RCTVirtualText>
</RCTTextView>

and the RCTVirtualText is a virtual component.
It is related with issue: #1455

Changes

  • Updated about.md docs

Checklist

  • Updated documentation

@piaskowyk piaskowyk self-assigned this Dec 7, 2020
docs/docs/about.md Outdated Show resolved Hide resolved
Co-authored-by: karol-bisztyga <[email protected]>
@piaskowyk piaskowyk merged commit c062f3d into master Dec 8, 2020
@piaskowyk piaskowyk deleted the docs_update branch December 8, 2020 15:18
cyanChill referenced this pull request in MissingCore/Music Jul 17, 2024
- Seems like with `v3.10.0` & `v3.11.0`, you could animate nested text components (ie: virtual components)
- With `v3.12.0` and beyond, it seems like this behavior was patched to the original behavior (noted back in December 2020)
  - `https://github.com/software-mansion/react-native-reanimated/pull/1510`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants