-
-
Notifications
You must be signed in to change notification settings - Fork 1k
[Web] Detector DOM props #3877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web] Detector DOM props #3877
Conversation
| if (config.enableContextMenu !== undefined) { | ||
| this.enableContextMenu = config.enableContextMenu; | ||
| } | ||
|
|
||
| if (config.touchAction !== undefined) { | ||
| this._touchAction = config.touchAction; | ||
| } | ||
|
|
||
| if (config.userSelect !== undefined) { | ||
| this._userSelect = config.userSelect; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like that we're relying on those being set before updating the enabled flag to apply changes. It would be great to handle this differently, but if that's not feasible, can there at least be a comment explaining this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR introduces missing web props to
NativeDetector.Test plan
Tested on the following code: