Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Clangd support #3069

Merged
merged 11 commits into from
Oct 3, 2024
Merged

feat: Clangd support #3069

merged 11 commits into from
Oct 3, 2024

Conversation

coado
Copy link
Contributor

@coado coado commented Aug 26, 2024

Description

This pull request introduces clangd support. You can read more about it in this awesome PR that bring it to reanimated. For now it supports iOS only as I am not sure if we need it for android here. To make it work, you have build FabricExample or MacOSExample first.

@coado
Copy link
Contributor Author

coado commented Aug 27, 2024

After building the FabricExample on android, the compile_commands.json file will contain only one translation unit, which is for cpp-adapter.cpp, since this is the only used cpp file on android.

@coado coado requested a review from j-piasecki October 1, 2024 13:23
Copy link
Member

@j-piasecki j-piasecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you merge main?

@coado coado merged commit c7c1a89 into main Oct 3, 2024
9 checks passed
@coado coado deleted the @dmalecki/clangd branch October 3, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants