Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1.3.14, fix LoggerManagement currency problem #192

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

HzjNeverStop
Copy link
Contributor

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33bad54) 35.12% compared to head (5a16bd9) 35.22%.

Additional details and impacted files
@@             Coverage Diff              @@
##                1.x     #192      +/-   ##
============================================
+ Coverage     35.12%   35.22%   +0.09%     
- Complexity      699      702       +3     
============================================
  Files            78       78              
  Lines          5794     5795       +1     
  Branches       1108     1108              
============================================
+ Hits           2035     2041       +6     
+ Misses         3498     3495       -3     
+ Partials        261      259       -2     
Files Coverage Δ
...ay/sofa/common/log/MultiAppLoggerSpaceManager.java 49.05% <100.00%> (+1.43%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HzjNeverStop HzjNeverStop changed the title 1.3.13 tracer Update 1.3.14, fix LoggerManagement currency problem Nov 7, 2023
@sofastack-cla sofastack-cla bot added the bug Something isn't working label Nov 7, 2023
Copy link

@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit ec236c2 into sofastack:1.x Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants