Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto transform SOFATracer Span in SOFA ThreadPool #191

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

HzjNeverStop
Copy link
Contributor

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (8d4ed1a) 34.69% compared to head (bf030fe) 35.12%.

Additional details and impacted files
@@             Coverage Diff              @@
##                1.x     #191      +/-   ##
============================================
+ Coverage     34.69%   35.12%   +0.43%     
- Complexity      680      699      +19     
============================================
  Files            77       78       +1     
  Lines          5742     5794      +52     
  Branches       1105     1108       +3     
============================================
+ Hits           1992     2035      +43     
- Misses         3494     3498       +4     
- Partials        256      261       +5     
Files Coverage Δ
...pay/sofa/common/thread/SofaThreadPoolExecutor.java 89.32% <100.00%> (+0.54%) ⬆️
...ofa/common/thread/SofaThreadPoolTaskScheduler.java 77.27% <100.00%> (+1.66%) ⬆️
...common/thread/SofaScheduledThreadPoolExecutor.java 97.97% <94.73%> (-0.82%) ⬇️
...sofa/common/thread/SofaThreadPoolTaskExecutor.java 79.62% <75.00%> (-0.38%) ⬇️
...y/sofa/common/thread/SofaTracerCommandFactory.java 62.50% <62.50%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 33bad54 into sofastack:1.x Oct 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants