THEOC-1722: Update dropdown to not close unless clicking outside

[JessicaTatham]

Dropdown doesn't close unless clicking outside of ref zone. Also expose isOpen as updatedIsOpen to allow component to control if we want alternative functionality.

How Has This Been Tested?

Types of changes

• New feature (non-breaking change which adds functionality)
• Improvement (non-breaking change which improves functionality or refactors code)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[jsteinb]

This seems like it fixes the issue. But I don't really get the use case for the controlledIsOpen prop, and the naming of it seems confusing. And this is changing the default behavior of the Dropdown so could be changing the behavior of anything that uses the Dropdown. Not sure if anything relied on the behavior as it was but we might want to keep the same defaults and override it in the place where you're using this?

[jsteinb]

do we also need to add the menuRef in the case where flyoutContainer == false? I get kind of unexpected behavior in your storybook story where flyoutContainer={false} when keepOpenOnClick is true, because it's passing menuRef into the useOutsideClick but not rendering any element with ref={menuRef}. Might be able to just do this on line 105:

<div ref={menuRef}>
  {children}
</div>