Skip to content

[SceneChecking] Update message for missing RequiredPlugin#6059

Merged
fredroy merged 1 commit intosofa-framework:masterfrom
hugtalbot:202603_requiredPlugin_warning_message
Apr 6, 2026
Merged

[SceneChecking] Update message for missing RequiredPlugin#6059
fredroy merged 1 commit intosofa-framework:masterfrom
hugtalbot:202603_requiredPlugin_warning_message

Conversation

@hugtalbot
Copy link
Copy Markdown
Contributor

@hugtalbot hugtalbot commented Mar 30, 2026

In order to foster good practices !


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Mar 30, 2026
Copy link
Copy Markdown
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the intention, but this code is a duplicate of SceneLoaderXML::syntaxForAddingRequiredPlugin which was already updated.

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 2, 2026
@fredroy fredroy force-pushed the 202603_requiredPlugin_warning_message branch from 346c934 to 705686d Compare April 5, 2026 23:44
@fredroy fredroy merged commit 78f1e1d into sofa-framework:master Apr 6, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants