Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mapping] Deprecate module Sofa.Component.Mapping.MappedMatrix #5070

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

alxbilger
Copy link
Contributor

[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/145]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 18, 2024
@sofabot
Copy link
Collaborator

sofabot commented Oct 18, 2024

[ci-depends-on] detected during build #1.

To unlock the merge button, you must

@fredroy
Copy link
Contributor

fredroy commented Oct 23, 2024

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Oct 23, 2024

[ci-depends-on] detected during build #2.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

Copy link
Contributor

@fredroy fredroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would almost directly delete it as it has been at least a year there is nothing of value inside 🤔
I suppose you want to be extra careful and warn people before deleting this module...

@alxbilger
Copy link
Contributor Author

I removed the module from the Sofa.Component.Mapping dependencies. I also removed all the files from the module. And there is a warning message if someone uses the module. In conclusion, the module exists only to warn that it should not be used.

@fredroy
Copy link
Contributor

fredroy commented Oct 24, 2024

I removed the module from the Sofa.Component.Mapping dependencies. I also removed all the files from the module. And there is a warning message if someone uses the module. In conclusion, the module exists only to warn that it should not be used.

Yes that is what I wanted to say 😅
Just I wanted to say that its content (components) itself was purged already one year ago

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 28, 2024
@sofabot
Copy link
Collaborator

sofabot commented Oct 28, 2024

[ci-depends-on] detected during build #3.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@sofabot
Copy link
Collaborator

sofabot commented Oct 29, 2024

[ci-depends-on] detected during build #4.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@sofabot
Copy link
Collaborator

sofabot commented Oct 29, 2024

[ci-depends-on] detected during build #5.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@fredroy
Copy link
Contributor

fredroy commented Oct 30, 2024

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Oct 30, 2024

[ci-depends-on] detected during build #6.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@fredroy
Copy link
Contributor

fredroy commented Oct 30, 2024

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Oct 30, 2024

[ci-depends-on] detected during build #7.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@sofabot
Copy link
Collaborator

sofabot commented Oct 30, 2024

[ci-depends-on] detected during build #8.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@fredroy fredroy merged commit 5fe2d61 into sofa-framework:master Oct 30, 2024
11 checks passed
@hugtalbot hugtalbot added this to the v24.12 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants