-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mapping] Deprecate module Sofa.Component.Mapping.MappedMatrix #5070
Conversation
[ci-depends-on] detected during build #1. To unlock the merge button, you must
|
[ci-build][with-all-tests][force-full-build] |
[ci-depends-on] detected during build #2. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would almost directly delete it as it has been at least a year there is nothing of value inside 🤔
I suppose you want to be extra careful and warn people before deleting this module...
I removed the module from the |
Yes that is what I wanted to say 😅 |
[ci-depends-on] detected during build #3. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
[ci-depends-on] detected during build #4. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
[ci-depends-on] detected during build #5. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
[ci-build][with-all-tests][force-full-build] |
[ci-depends-on] detected during build #6. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
[ci-build][with-all-tests][force-full-build] |
[ci-depends-on] detected during build #7. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
[ci-depends-on] detected during build #8. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/145]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if