[Binding/Sofa.Core] Implement a custom getClassName() for trampoline classes.#179
Merged
damienmarchal merged 1 commit intosofa-framework:masterfrom Sep 17, 2021
Conversation
…classes. Trampoline classes are used to implement sofa components in python. The default getClassName() returns the name of the c++ trampoline class name instead of the name of the python overrides. This is why you can see stuff like that: ``` Controller_Trampoline(myObject) ForceField_Trampoline(myFF) ``` This PR retrieve the real class name from python to returns it in a custom getClassName. Eg: ``` class RoboticsController(Sofa.Core.Controller): pass ``` will appears with its real name in the GUI: ``` RoboticController(myObject) ```
damienmarchal
force-pushed
the
pr-add-getclassname-when-overriding-from-python
branch
from
b561934 to
2a7b06d
Compare
damienmarchal
deleted the
pr-add-getclassname-when-overriding-from-python
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trampoline classes are used to implement sofa components in python.
When used, the default getClassName() (what is showed in the GUI) returns the name of the c++ trampoline class name instead
of the name of the python overrides.
This is why you can see stuff like that in the GUI:
This PR change this behavior to retrieve the real class name from python and returns it in getClassName.
So python code like that:
Will appears with its real name in the GUI: