Add PR template for soda-extensions reminder #2494
Merged
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had a few times where the soda-extensions package was broken as a result of changes in soda-core. There is a workflow in place to validate they work together correctly, but this is a manual process. This PR adds a template to promote good PR practices, including a reminder to run the soda-extensions workflow for validating compatibility.
|
Niels-b
approved these changes
Nov 24, 2025
Niels-b
left a comment
Niels-b
left a comment
There was a problem hiding this comment.
LGTM! Let's hope this works when we merge it 🤞 . (Non breaking change, so good to go anyway).
paulteehan
approved these changes
Nov 24, 2025
paulteehan
left a comment
paulteehan
left a comment
There was a problem hiding this comment.
I love it, a very simple approach which I bet will catch a good chunk of problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a few times where the soda-extensions package was broken as a result of changes in soda-core. There is a workflow in place to validate they work together correctly, but this is a manual process.
This PR adds a template to promote good PR practices, including a reminder to run the soda-extensions workflow for validating compatibility.
Note
This is an attempt, but I'm not sure this will work as-is. The github docs specify that the template needs to live on the default branch of the repository. In our case that would be
main, but I don't think we want to place this template there assoda-extensionsis not relevant for themainbranch (v3).