Skip to content

Add missing mappings #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v4
Choose a base branch
from
Open

Add missing mappings #2430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1150452
Add missing mappings
paulteehan Oct 6, 2025
f43f43b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion soda-bigquery/src/soda_bigquery/common/data_sources/bigquery_data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,13 @@ def get_soda_data_type_name_by_data_source_data_type_names(self) -> dict[str, So
"timestamp": SodaDataTypeName.TIMESTAMP,
"date": SodaDataTypeName.DATE,
"time": SodaDataTypeName.TIME,
"datetime": SodaDataTypeName.TIMESTAMP,
"bool": SodaDataTypeName.BOOLEAN,
}

def _get_data_type_name_synonyms(self) -> list[list[str]]:
return [
["int64", "integer"],
["int64", "integer", "int", "bigint", "tinyint", "byteint"],
["bool", "boolean"],
["numeric", "decimal"],
["bignumeric", "bigdecimal"],
Expand Down
1 change: 1 addition & 0 deletions soda-postgres/src/soda_postgres/common/data_sources/postgres_data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ def _get_data_type_name_synonyms(self) -> list[list[str]]:
[PG_DOUBLE_PRECISION, "float8"],
["timestamp", PG_TIMESTAMP_WITHOUT_TIME_ZONE],
["decimal", "numeric"],
["boolean", "bool"],
]

def get_sql_data_type_class(self) -> type:
Expand Down