Making sure that the parameters provided in the metadatalocation getting passed to the nfs provider #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineela1999
changed the title
| }, | ||
| }, | ||
| }) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| log.Infof("88888attributes are:8888 %v", attributes) |
There was a problem hiding this comment.
please do change the logs properly.....don't add 888 etc . please do change this all the places
| }, | ||
| } | ||
| ctrl.logger.Infof("paramteres in deleteMetadataBackup:%v", parameters) |
| }, | ||
| }, | ||
| }) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| log.Infof("attributes in upload are: %v", attributes) |
There was a problem hiding this comment.
Follow log msg convention, applicable for other places as well
| } | ||
| log.Infof("***parameters are******%v", parameters) |
| // Validate the Metadatalocation | ||
| locationName := backup.Spec.MetadataLocation | ||
| backup.Status.ValidationErrors = []string{} | ||
| ctrl.logger.Infof("Preparing backup for backup location: %s ", locationName) |
There was a problem hiding this comment.
This is the delete flow, update accordingly
| @@ -277,11 +279,23 @@ func (ctrl *controller) deleteMetadataBackup(backup *kahuapi.Backup) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // Validate the Metadatalocation | |||
| locationName := backup.Spec.MetadataLocation | |||
| backup.Status.ValidationErrors = []string{} | |||
There was a problem hiding this comment.
Not required to update ValidationErrors
| @@ -165,8 +167,11 @@ func (server *nfsServer) Download(request *pb.DownloadRequest, | |||
| if fileId == "" { | |||
| return status.Error(codes.InvalidArgument, "download file id is empty") | |||
| } | |||
| attributes := request.GetAttributes() | |||
| log.Infof("******attributes in Download are***** %v", attributes) | |||
There was a problem hiding this comment.
Combine this with subsequent log
| @@ -226,6 +231,10 @@ func (server *nfsServer) Delete(ctxt context.Context, | |||
| log.Info("Delete Called ...") | |||
|
|
|||
| fileId := request.GetFileIdentifier() | |||
|
|
|||
| attributes := request.GetAttributes() | |||
| log.Infof("******attributes in Delete are***** %v", attributes) | |||
There was a problem hiding this comment.
Combine this with subsequent log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind bug fix
What this PR does / why we need it:
The parameters provided in the metadatalocation should be reached to the NFS provider
this PR implements the code required for that
Which issue(s) this PR fixes:
Fixes #
Test Report Added?:
kind TESTED
Test Report:
for the resource:
when trying to restore backup and delete backup parameters are getting passed
Special notes for your reviewer: