Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental buffer flushing after session was closed #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrjoes
Copy link
Member

@mrjoes mrjoes commented Oct 10, 2012

Few notes:

  1. Not sure if it should check response_pid from the state.
  2. I tried it locally with different transports - appears to be working

@ghost ghost assigned hyperthunk May 14, 2013
@hyperthunk
Copy link
Contributor

Hi @mrjoes - can you explain the rationale behind this patch for me please? I'm happy to do the QA and merge, but I need to properly understand the intent first.

@mrjoes
Copy link
Member Author

mrjoes commented May 14, 2013

Sure. For polling transports, when server closes connection, there might be something left in the outgoing queue. However, when client comes back to get more data, server sees that session was closed and will deny the request without flushing the queue.

So, it is not working according to websocket spec.

@hyperthunk
Copy link
Contributor

Right, that makes sense. Let me read through the spec and spend a but of time looking over the code. Hopefully I'll be able to answer (1) and we can get it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants