Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hibernate sockjs_session process #25

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

hibernate sockjs_session process #25

wants to merge 8 commits into from

Conversation

rounce
Copy link

@rounce rounce commented Apr 13, 2012

No description provided.

@ghost ghost assigned hyperthunk May 14, 2013
@hyperthunk
Copy link
Contributor

Hi @rounce - thanks for the patch, and sorry that it has taken this long to look at it. I'm just getting up to speed at the moment, so it'd be good to understand the intent of this patch a bit better. Presumably the goal is to make an idle session hibernate and thus save memory. That sounds sensible to me.

This pull request presents 8 separate commits, some of which are fixes. That will break git bisect if it's merged as is, so can you please squash these down to a single commit (using git rebase -i HEAD~8 or whatever) so that when we merge, we get a nice clean (and bisect-able) history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants