Skip to content

Conversation

costa
Copy link

@costa costa commented Oct 3, 2021

Description

Support for:

  • origin certificates (securing connection from cloudflare to the origin server)
  • back-end CIDRs (restricting the origin server's access to cloudflare back end only)

Types of Changes

  • New feature.

Testing

  • I added tests for my changes.
    • and I'd like to add tests, but couldn't figure the test setup, so this is a draft PR
      • I usually have bin/test that runs the suite in a dockerised environment
  • I tested my changes in production.
    • and it worked perfectly

@costa
Copy link
Author

costa commented Jul 1, 2025

@9mm I understand that you might be the owner of this gem now. Thank you for your work!

If you can review this draft PR and comment on what should be done in order to merge it -- in addition to resolving the conflicts, of course -- I'll do that -- I've been using this functionality in production for many years now.

@9mm
Copy link
Contributor

9mm commented Jul 1, 2025

hey it is actually @ioquatix

@ioquatix
Copy link
Member

ioquatix commented Jul 2, 2025

Can you rebase it on main and let's try to implement some tests.

@costa
Copy link
Author

costa commented Jul 6, 2025

@ioquatix oh-oh, even before the new tests, some old tests are failing; could you help me make sense of https://github.com/costa/cloudflare/actions/runs/16102570476/job/45433595059
Thank you
FYI, in my production (with this specific functionality used) so far, it works.

@ioquatix
Copy link
Member

ioquatix commented Jul 7, 2025

Yeah, I will spend some time trying to untangle this, this week. CI for this gem is complicated because it runs proper integration tests, but that sometimes has issues.

@costa
Copy link
Author

costa commented Aug 20, 2025

@ioquatix ping ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants