Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'm not sure what I was planning to do with this. #109

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/async/http/server.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def initialize(app, endpoint, protocol: endpoint.protocol, scheme: endpoint.sche
attr :protocol
attr :scheme

def accept(peer, address, task: Task.current)
def accept(peer, address)
connection = @protocol.server(peer)

Console.logger.debug(self) {"Incoming connnection from #{address.inspect} to #{@protocol}"}
Expand All @@ -70,8 +70,8 @@ def accept(peer, address, task: Task.current)
connection&.close
end

def run
@endpoint.accept(&self.method(:accept))
def run(**options)
@endpoint.accept(**options, &self.method(:accept))
end

Traces::Provider(self) do
Expand Down
36 changes: 36 additions & 0 deletions spec/async/http/server_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# Copyright, 2020, by Samuel G. D. Williams. <http://www.codeotaku.com>
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in
# all copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.

require_relative 'server_context'

RSpec.describe Async::HTTP::Server do
include_context Async::HTTP::Server

let(:server) do
Async::HTTP::Server.for(@bound_endpoint) do |request|
Async::Task.current.sleep(delay)
Protocol::HTTP::Response[200, {}, []]
end
end

it 'can bind to one or more sockets' do
pp barrier
end
end