Flexibilize CMake version and add Conan steps in docs #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
|
Hi, thanks for the additions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In this PR I tried new changes that I hope be useful for users, including:
Before the PR build: Bump CMake version #406, the FATAL_ERROR in CMakeLists.txt version was related to avoid running older versions. Later, was added a maximum CMake version, but the CMake is very compatible between a version and other, so I removed the FATAL_ERROR to allow running the latest CMake version available (3.29.x)
When consuming Asio, both CMake target (asio::asio) and the library asio are consumed, causing double inclusion. I removed the library to keep CMake target are preference.
After merging the PR [sioclient] Build static libraries in Windows conan-io/conan-center-index#24176 in ConanCenterIndex, the socket-io client cpp is now available in Conan Center (https://conan.io/center/recipes/sioclient?version=cci.20240405) and can be installed via Conan commands. I added an entry in the documentation to explain how to install sioclient via Conan.
Regards!