refactor: move the req attribute to the polling class

socketio · Jun 21, 2024 · 6d8a0be · 6d8a0be
1 parent c310b7b
commit 6d8a0be
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/lib/transport.ts b/lib/transport.ts
@@ -54,7 +54,6 @@ export abstract class Transport extends EventEmitter {
    * @protected
    */
   protected parser: any;
-  protected req: EngineRequest;
   /**
    * Whether the transport supports binary payloads (else it will be base64-encoded)
    * @protected
@@ -99,13 +98,10 @@ export abstract class Transport extends EventEmitter {
   /**
    * Called with an incoming HTTP request.
    *
-   * @param {http.IncomingMessage} req
+   * @param req
    * @package
    */
-  onRequest(req) {
-    debug("setting request");
-    this.req = req;
-  }
+  onRequest(req: any) {}
 
   /**
    * Closes the transport.

diff --git a/lib/transports-uws/polling.ts b/lib/transports-uws/polling.ts
@@ -15,6 +15,7 @@ export class Polling extends Transport {
   public maxHttpBufferSize: number;
   public httpCompression: any;
 
+  private req: HttpRequest & { cleanup: () => void };
   private res: HttpResponse;
   private dataReq: HttpRequest;
   private dataRes: HttpResponse;

diff --git a/lib/transports/polling.ts b/lib/transports/polling.ts
@@ -16,6 +16,7 @@ export class Polling extends Transport {
   public maxHttpBufferSize: number;
   public httpCompression: any;
 
+  private req: EngineRequest;
   private res: ServerResponse;
   private dataReq: IncomingMessage;
   private dataRes: ServerResponse;