fixed ACSDataset assignment of new task

socialfoundations · Jun 24, 2024 · a2d9f62 · a2d9f62
1 parent 3967801
commit a2d9f62
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/folktexts/acs/acs_dataset.py b/folktexts/acs/acs_dataset.py
@@ -46,7 +46,7 @@ def __init__(
         )
 
     @classmethod
-    def make_acs_dataset(
+    def make_from_task(
         cls,
         task: str | ACSTaskMetadata,
         cache_dir: str | Path = None,
@@ -113,8 +113,7 @@ def task(self) -> ACSTaskMetadata:
 
     @task.setter
     def task(self, new_task: ACSTaskMetadata):
-        import ipdb; ipdb.set_trace()
-        self._data = self._parse_task_data(self._full_data, new_task)
+        self._data = self._parse_task_data(self._full_acs_data, new_task)
         super().task = new_task
 
     @classmethod

diff --git a/folktexts/benchmark.py b/folktexts/benchmark.py
@@ -383,7 +383,7 @@ def make_acs_benchmark(
 
         # Fetch ACS task and dataset
         acs_task = ACSTaskMetadata.get_task(task_name)
-        acs_dataset = ACSDataset.make_acs_dataset(
+        acs_dataset = ACSDataset.make_from_task(
             task_obj=acs_task,
             cache_dir=data_dir,
             **acs_dataset_configs)