Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dcr #389

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Update dcr #389

merged 5 commits into from
Mar 15, 2024

Conversation

Allonck
Copy link
Collaborator

@Allonck Allonck commented Mar 14, 2024

Fixed the dcr method, it was a problem with the path of the files, my initial thought was a problem with the change of directory in the subprocess. This should close #388

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.97%. Comparing base (b3a57ce) to head (cf2f4b3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #389   +/-   ##
=======================================
  Coverage   79.96%   79.97%           
=======================================
  Files          15       15           
  Lines        2641     2642    +1     
=======================================
+ Hits         2112     2113    +1     
  Misses        529      529           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Allonck Allonck changed the title Update dcr [WIP] Update dcr Mar 15, 2024
@Allonck Allonck changed the title [WIP] Update dcr Update dcr Mar 15, 2024
@simontorres
Copy link
Member

closes #388

@simontorres simontorres merged commit 1ede463 into soar-telescope:main Mar 15, 2024
8 checks passed
@Allonck Allonck deleted the updateDCR branch March 15, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DCR doesn't work with CLI
2 participants