-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/testing-prs #138
base: master
Are you sure you want to change the base?
chore/testing-prs #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close to perfect! Please address the suggested inline change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close to perfect! Please address the suggested inline change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close to perfect! Please address the suggested inline change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close to perfect! Please address the suggested inline change.
This is a comment on the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close to perfect! Please address the suggested inline change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close to perfect! Please address the suggested inline change.
@@ -62,7 +61,7 @@ function parse(todo) { | |||
time = time.replace(/\n$/, ''); | |||
|
|||
var period = hms(time); | |||
|
|||
var shir = "DoNotMerge"; | |||
console.log('period: ' + period); | |||
|
|||
// remove it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new isuee on line 67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close to perfect! Please address the suggested inline change.
// ** express turns the cookie key to lowercase ** | ||
exports.current_user = function (req, res, next) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new isuee on line 144-145
@@ -6,7 +6,6 @@ var User = mongoose.model('User'); | |||
var hms = require('humanize-ms'); | |||
var ms = require('ms'); | |||
var streamBuffers = require('stream-buffers'); | |||
var readline = require('readline'); | |||
var moment = require('moment'); | |||
var exec = require('child_process').exec; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new isuee on line 11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close to perfect! Please address the suggested inline change.
// ** express turns the cookie key to lowercase ** | ||
exports.current_user = function (req, res, next) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new isuee on line 144-145
@@ -6,7 +6,6 @@ var User = mongoose.model('User'); | |||
var hms = require('humanize-ms'); | |||
var ms = require('ms'); | |||
var streamBuffers = require('stream-buffers'); | |||
var readline = require('readline'); | |||
var moment = require('moment'); | |||
var exec = require('child_process').exec; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new isuee on line 11
DO NOT MERGE