Repository navigation
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alina-d-m
force-pushed
the
chore/PS-865/clean-up-CB-feature-flag-usage
branch
from
October 16, 2026 07:41
f10d94c to
e5769de
Compare
This comment has been minimized.
This comment has been minimized.
alina-d-m
force-pushed
the
chore/PS-865/clean-up-CB-feature-flag-usage
branch
from
October 16, 2026 09:13
e5769de to
552b5ab
Compare
This comment has been minimized.
This comment has been minimized.
alina-d-m
force-pushed
the
chore/PS-865/clean-up-CB-feature-flag-usage
branch
from
October 16, 2026 12:51
552b5ab to
27fcd87
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 27fcd87. Configure here.
alina-d-m
force-pushed
the
chore/PS-865/clean-up-CB-feature-flag-usage
branch
from
October 22, 2026 10:58
27fcd87 to
4b01abb
Compare
This comment has been minimized.
This comment has been minimized.
alina-d-m
force-pushed
the
chore/PS-865/clean-up-CB-feature-flag-usage
branch
from
October 22, 2026 11:40
4b01abb to
95d0bab
Compare
This comment has been minimized.
This comment has been minimized.
alina-d-m
force-pushed
the
chore/PS-865/clean-up-CB-feature-flag-usage
branch
from
October 22, 2026 12:40
95d0bab to
bbd0359
Compare
This comment has been minimized.
This comment has been minimized.
robertolopezlopez
approved these changes
Oct 23, 2026
robertolopezlopez
left a comment
Contributor
There was a problem hiding this comment.
approving with some a minor finding - please take care of it
alina-d-m
force-pushed
the
chore/PS-865/clean-up-CB-feature-flag-usage
branch
from
October 23, 2026 10:37
bbd0359 to
18cdf2f
Compare
This comment has been minimized.
This comment has been minimized.
alina-d-m
enabled auto-merge
October 23, 2026 10:50
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
alina-d-m
force-pushed
the
chore/PS-865/clean-up-CB-feature-flag-usage
branch
from
October 23, 2026 12:57
18cdf2f to
4a8a8fd
Compare
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Updates the secrets extension to the latest version. The latest version of the extension removes the usage of the 'isSecretsEnabled' feature flag in favor (used during CB) of using only the Secrets setting to gate Secrets tests.
Also updates the tests to mock the setting rather than the FF.
Where should the reviewer start?
From the extension's clean-up PR snyk/cli-extension-secrets#96.
How should this be manually tested?
Build the cli and run 'snyk secrets test' with and without the Secrets setting on. If the setting is turned off, 'snyk secrets test' should prevent you from running a Secrets scan.
What's the product update that needs to be communicated to CLI users?
None.
Note
Medium Risk
Changes when
snyk secrets testis allowed (org setting vs legacy FF); behavior should match product intent but affects all Secrets CLI users at scan start.Overview
Bumps
cli-extension-secretsincliv2andcliv2-privateso Secrets gating uses the org Secrets setting (REST) instead of theisSecretsEnabledfeature flag.Acceptance tests are aligned with that behavior: the fake server exposes
GET /rest/orgs/:orgId/settings/secrets(with and without/api), driven bysetOrgSetting('secrets', …). Resilience and secrets HTML/user-journey specs dropINTERNAL_SNYK_FEATURE_FLAG_IS_SECRETS_ENABLED/setFeatureFlag('isSecretsEnabled')and opt in via the org setting. A new HTML test assertssnyk secrets testfails closed (SNYK-CLI-0016, no test job) when the setting is off.Reviewed by Cursor Bugbot for commit 18cdf2f. Bugbot is set up for automated code reviews on this repo. Configure here.