Skip to content

chore: clean up featur flag usage [PS-865] - #7379

Open
alina-d-m wants to merge 1 commit into
mainfrom
chore/PS-865/clean-up-CB-feature-flag-usage
Open

alina-d-m wants to merge 1 commit into
mainfrom
chore/PS-865/clean-up-CB-feature-flag-usage

Conversation

@alina-d-m

@alina-d-m alina-d-m commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Updates the secrets extension to the latest version. The latest version of the extension removes the usage of the 'isSecretsEnabled' feature flag in favor (used during CB) of using only the Secrets setting to gate Secrets tests.

Also updates the tests to mock the setting rather than the FF.

Where should the reviewer start?

From the extension's clean-up PR snyk/cli-extension-secrets#96.

How should this be manually tested?

Build the cli and run 'snyk secrets test' with and without the Secrets setting on. If the setting is turned off, 'snyk secrets test' should prevent you from running a Secrets scan.

What's the product update that needs to be communicated to CLI users?

None.


Note

Medium Risk
Changes when snyk secrets test is allowed (org setting vs legacy FF); behavior should match product intent but affects all Secrets CLI users at scan start.

Overview
Bumps cli-extension-secrets in cliv2 and cliv2-private so Secrets gating uses the org Secrets setting (REST) instead of the isSecretsEnabled feature flag.

Acceptance tests are aligned with that behavior: the fake server exposes GET /rest/orgs/:orgId/settings/secrets (with and without /api), driven by setOrgSetting('secrets', …). Resilience and secrets HTML/user-journey specs drop INTERNAL_SNYK_FEATURE_FLAG_IS_SECRETS_ENABLED / setFeatureFlag('isSecretsEnabled') and opt in via the org setting. A new HTML test asserts snyk secrets test fails closed (SNYK-CLI-0016, no test job) when the setting is off.

Reviewed by Cursor Bugbot for commit 18cdf2f. Bugbot is set up for automated code reviews on this repo. Configure here.

@alina-d-m
alina-d-m requested review from a team as code owners October 15, 2026 11:32
@snyk-io

snyk-io Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-pr-review-bot

This comment has been minimized.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread cliv2/go.mod
@snyk-pr-review-bot

This comment has been minimized.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread test/acceptance/fake-server.ts Outdated
@snyk-pr-review-bot

This comment has been minimized.

@alina-d-m
alina-d-m force-pushed the chore/PS-865/clean-up-CB-feature-flag-usage branch from f10d94c to e5769de Compare October 16, 2026 07:41
@snyk-pr-review-bot

This comment has been minimized.

@alina-d-m
alina-d-m force-pushed the chore/PS-865/clean-up-CB-feature-flag-usage branch from e5769de to 552b5ab Compare October 16, 2026 09:13
@snyk-pr-review-bot

This comment has been minimized.

@alina-d-m
alina-d-m force-pushed the chore/PS-865/clean-up-CB-feature-flag-usage branch from 552b5ab to 27fcd87 Compare October 16, 2026 12:51
@snyk-pr-review-bot

This comment has been minimized.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 27fcd87. Configure here.

Comment thread test/acceptance/fake-server.ts
@alina-d-m
alina-d-m force-pushed the chore/PS-865/clean-up-CB-feature-flag-usage branch from 27fcd87 to 4b01abb Compare October 22, 2026 10:58
@snyk-pr-review-bot

This comment has been minimized.

@alina-d-m
alina-d-m force-pushed the chore/PS-865/clean-up-CB-feature-flag-usage branch from 4b01abb to 95d0bab Compare October 22, 2026 11:40
@snyk-pr-review-bot

This comment has been minimized.

@alina-d-m
alina-d-m force-pushed the chore/PS-865/clean-up-CB-feature-flag-usage branch from 95d0bab to bbd0359 Compare October 22, 2026 12:40
@snyk-pr-review-bot

This comment has been minimized.

Comment thread test/jest/acceptance/snyk-secrets/snyk-secrets-html.spec.ts Outdated

@robertolopezlopez robertolopezlopez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with some a minor finding - please take care of it

@alina-d-m
alina-d-m force-pushed the chore/PS-865/clean-up-CB-feature-flag-usage branch from bbd0359 to 18cdf2f Compare October 23, 2026 10:37
@snyk-pr-review-bot

This comment has been minimized.

@alina-d-m
alina-d-m enabled auto-merge October 23, 2026 10:50
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@alina-d-m
alina-d-m force-pushed the chore/PS-865/clean-up-CB-feature-flag-usage branch from 18cdf2f to 4a8a8fd Compare October 23, 2026 12:57
@snyk-pr-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected
📚 Repository Context Analyzed

This review considered 7 relevant code sections from 5 files (average relevance: 1.00)

🤖 Repository instructions applied (from AGENTS.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants