feat: add license instructions to human readable output #84
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
snyk-will
force-pushed
the
feat/add_license_instructions
branch
from
1adf52a to
303557a
Compare
internal/presenters/__snapshots__/presenter_unified_finding_test.snap
Outdated
Show resolved
Hide resolved
snyk-will
force-pushed
the
feat/add_license_instructions
branch
from
4f48c4d to
b41c292
Compare
| if inst.Content == "" { | ||
| continue | ||
| } | ||
| instructions = append(instructions, fmt.Sprintf(" %s for %s: %s", bulletPoint, inst.License, inst.Content)) |
There was a problem hiding this comment.
From a quick look at the CLI screenshot here it looks like some of the text is bold, coloured etc., e.g. in this line everything from the bullet point to the colon is white and the text after is grey. Do we need to mirror this here? (The formatting might be happening elsewhere so I might be missing something)
There was a problem hiding this comment.
Not sure how easy/hard it is to do and whether we even want it, just wondering out of curiosity
There was a problem hiding this comment.
yeah I don't think that's too hard to add, however, it looks like the other fields (reachability, risk score etc.) are not in bold so I don't want to have this as the only field that stands out. @paulrosca-snyk do you have any insight? I can see you working on reachability rendering atm
4 participants
Add functionality to render license instructions in the human readable output.
https://snyksec.atlassian.net/browse/UNIFY-926