Allow disabling activity tracking actions (close #1161) #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igneel64
force-pushed
the
feature/1161-allow-disabling-activity-tracking
branch
from
3d53351
to
05bd678
Compare
BundleMonFiles added (6)
Total files change +95.6KB 0% Final result: ✅ View report in BundleMon website ➡️ |
matus-tomlein
approved these changes
Aug 8, 2023
| window.clearInterval(callbackConfiguration?.activityInterval); | ||
| } | ||
|
|
||
| activityTrackingConfig.configurations[actionKey] = undefined; |
There was a problem hiding this comment.
I'm wondering, should we also set activityTrackingConfig.enabled to false in case there are no more configurations left? From what I can tell it'd be more like a cosmetic change and not have much effect on anything (in which case do we really need the flag?), but wondering if you can see some reason to or considered it.
There was a problem hiding this comment.
The enabled flag seems to be mostly used for the activity tracking at the start and between pageviews. It does not have control over the interval/timeouts of the actual pinging.
It was the first thing I tried 😄
matus-tomlein
force-pushed
the
release/3.14.0
branch
from
ed9bbba
to
0b3950a
Compare
greg-el
pushed a commit
that referenced
this pull request
Aug 10, 2023
greg-el
pushed a commit
that referenced
this pull request
Aug 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
disableActivityTrackinganddisableActivityTrackingCallbackto disable the respective activity tracking and activity tracking callbacks from the tracker.