Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev maybe t #52

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Dev maybe t #52

wants to merge 3 commits into from

Conversation

turion
Copy link
Collaborator

@turion turion commented Jun 23, 2022

@turion
Copy link
Collaborator Author

turion commented Jun 23, 2022

Ah, the whole deriving via story doesn't work on older GHCs. Which makes this refactoring a bit pointless. If it's fine for you I'll leave this PR hanging round until maybe one day those older versions are dropped.

@snowleopard
Copy link
Owner

Hmm, unlocking DerivingVia seems like a pretty solid reason to drop support for older GHCs.

@vrom911 I can see that validation-selective currently supports GHC 8.4. How sad will you be if selective stops supporting it?

@snowleopard
Copy link
Owner

I went ahead and dropped support for older GHC versions, so we can now use DerivingVia!

Would you like to finish this PR? Happy to do this myself since I made some changes that might make rebasing this a bit tedious.

@turion
Copy link
Collaborator Author

turion commented Feb 20, 2023

Feel free to do it yourself, I can't come back to it in the next few weeks.

@Kleidukos
Copy link
Contributor

Kleidukos commented Jan 25, 2024

@snowleopard I can probably make that kind of call regarding validation-selective in the future, since @tomjaguarpaw and I are maintainers for the lib now. :)

@snowleopard
Copy link
Owner

@Kleidukos Cool, thanks :) What's the last version of GHC that you support?

@tomjaguarpaw
Copy link

9.8

@snowleopard
Copy link
Owner

9.8

@tomjaguarpaw Oops, sorry, I meant to ask about the oldest supported version.

@tomjaguarpaw
Copy link

@snowleopard
Copy link
Owner

Got it, thanks! With #78 landing, selective supports the same version range, though I wonder if I should drop a few older versions. It's unclear if it's worth supporting so many versions.

@tomjaguarpaw
Copy link

What's the cost to supporting them?

@snowleopard
Copy link
Owner

What's the cost to supporting them?

CPP noise, CI time, and even just needing to think about them.

@tomjaguarpaw
Copy link

Yeah, it's hard to know whether the cost is worth paying without knowing how many people are continuing to use the package on older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants