-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev maybe t #52
base: main
Are you sure you want to change the base?
Dev maybe t #52
Conversation
Ah, the whole |
Hmm, unlocking @vrom911 I can see that |
I went ahead and dropped support for older GHC versions, so we can now use DerivingVia! Would you like to finish this PR? Happy to do this myself since I made some changes that might make rebasing this a bit tedious. |
Feel free to do it yourself, I can't come back to it in the next few weeks. |
@snowleopard I can probably make that kind of call regarding |
@Kleidukos Cool, thanks :) What's the last version of GHC that you support? |
9.8 |
@tomjaguarpaw Oops, sorry, I meant to ask about the oldest supported version. |
8.6, as confirmed by our test suite: https://github.com/kowainik/validation-selective/blob/a99a6610958090e55fa48ab936736471f1589691/.github/workflows/ci.yml#L24. |
Got it, thanks! With #78 landing, |
What's the cost to supporting them? |
CPP noise, CI time, and even just needing to think about them. |
Yeah, it's hard to know whether the cost is worth paying without knowing how many people are continuing to use the package on older versions. |
See #39 (comment) and #37 (comment)