[SNOW-3203938] Fix ai_parse_document_basic test#4109
Open
sfc-gh-mrek wants to merge 3 commits intomainfrom
Open
[SNOW-3203938] Fix ai_parse_document_basic test#4109sfc-gh-mrek wants to merge 3 commits intomainfrom
sfc-gh-mrek wants to merge 3 commits intomainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
e6900b3 to
5fe5853
Compare
sfc-gh-aling
reviewed
Mar 6, 2026
Comment on lines
+1076
to
+1078
| session.sql( | ||
| "ALTER SESSION SET AI_SQL_ERROR_HANDLING_USE_FAIL_ON_ERROR = FALSE" | ||
| ).collect() |
Contributor
There was a problem hiding this comment.
we normally do not do this because our tests run in parallel and it might pollute other test
sfc-gh-aling
requested changes
Mar 6, 2026
sfc-gh-joshi
reviewed
Mar 6, 2026
|
|
||
| - Fixed a bug in `Session.client_telemetry` that trace does not have snowflake style trace id. | ||
| - Fixed a bug in `ai_complete` where `model_parameters` and `response_format` values containing single quotes would generate malformed SQL. | ||
| - Fixed a ai_parse_document test that failed with new error handling |
Contributor
There was a problem hiding this comment.
Suggested change
| - Fixed a ai_parse_document test that failed with new error handling |
Test-only fixes shouldn't have changelog entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-3203938
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
With latest changes related to the new error handling, basic parse document tests started failing because metadata key is mising in the response.
This is expected behaviour, more details can be found here.
I've modified tests to use session parameter, to test both legacy and new response without error details (the bcr process lasts ~3 months, so during this time both combinations will be available for clients).
It affects ai_parse_document only, as for other functions the value didn't change.
New response type is {value:, error}, but when response error details are disabled, value is extracted.
In case of ai_parse_document, metadata was moved to the root level of the response {value,metadata,error} making it absent in value.
As a follow-up, it would be a good idea to cover new error handling with error details in these tests.