Rename permissions skip env var and deprecate old one with tests#2781
Open
sfc-gh-turbaszek wants to merge 2 commits intomainfrom
Open
Rename permissions skip env var and deprecate old one with tests#2781sfc-gh-turbaszek wants to merge 2 commits intomainfrom
sfc-gh-turbaszek wants to merge 2 commits intomainfrom
Conversation
Replace SF_SKIP_WARNING_FOR_READ_PERMISSIONS_ON_CONFIG_FILE with SF_SKIP_TOKEN_FILE_PERMISSIONS_VERIFICATION, keeping backward compatibility by falling back to the deprecated env var with a deprecation warning. Add unit tests covering the new/deprecated env var logic and precedence. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace SF_SKIP_WARNING_FOR_READ_PERMISSIONS_ON_CONFIG_FILE with SF_SKIP_TOKEN_FILE_PERMISSIONS_VERIFICATION, keeping backward compatibility by falling back to the deprecated env var with a deprecation warning. Add unit tests covering the new/deprecated env var logic and precedence.
Made-with: Cursor
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
(Optional) PR for stored-proc connector: