[MacOS] Fullscreen fix #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable tabs creation when opening a window from a fullscreened window * Fix crash when disconnecting while having a fullscreened child window
Namaneo
force-pushed
the
fullscreen_fix
branch
from
c2da3d7
to
c1b5154
Compare
RonaldH-Parsec
suggested changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has few goals:
MTY_Frame. IMO, it also felt weird to have very different visual results when calling the exact same entry function with the exact same parameters, depending on the state of the application.[NSWindow close]function being asynchronous, some events can still be fired after thestruct windowhas been free'd (here, a resize event). The internal context is now nullified and null-checks have been added in event handlers.