metrics-server: try replacing helm with kustomize #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just merged a PR that switches to CircleCI so you shouldn't hit the invalid-token issue anymore with this after rebasing onto master. |
This PR proposes the use of the kustomize included in `kubectl` instead of the third-party `helm` to deploy metrics-server. The way this works is roughly: 1. create a DOKS cluster (just like before) 1. clone `kubernetes-incubator/metrics-server` at a specific git ref 1. call `kubectl kustomize` in the `metrics-server` directory * this makes use of the `kustomization.yaml` file in the `metrics-server` directory * the `kustomization.yaml` file points at example deployment manifests in the cloned `kubernetes-incubator/metrics-server` directory * the `kustomization.yaml` patches the upstream example deployment manifests with settings similar to what came with the `helm` chart 1. just like before, wait until the `metrics-server` pod(s) are ready One major difference from the `helm` chart is that with `helm` it was easy to deploy `metrics-server` to its own namespace whereas the upstream example manifests on which the `kustomize` approach is based assume deployment in `kube-system`. It wasn't straightforward to use `kustomize` patches or bases to do something similar -- I'm sure it's possible, I just haven't found the minimal set of patches necessary yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes the use of the kustomize included in
kubectlinstead of the third-partyhelmto deploy metrics-server.The way this works is roughly:
kubernetes-incubator/metrics-serverat a specific git refkubectl kustomizein themetrics-serverdirectorykustomization.yamlfile in themetrics-serverdirectorykustomization.yamlfile points at example deployment manifests in the clonedkubernetes-incubator/metrics-serverdirectorykustomization.yamlpatches the upstream example deployment manifests with settings similar to what came with thehelmchartmetrics-serverpod(s) are readyOne major difference from the
helmchart is that withhelmit was easy to deploymetrics-serverto its own namespace whereas the upstream example manifests on which thekustomizeapproach is based assume deployment inkube-system. It wasn't straightforward to usekustomizepatches or bases to do something similar -- I'm sure it's possible, I just haven't found the minimal set of patches necessary yet.