Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fx: exclude fields typo #69

Merged
merged 14 commits into from
Oct 1, 2024
Merged

fx: exclude fields typo #69

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0cefdf9
fx: exclude fields typo
whatphilipcodes Sep 20, 2024
bbec71e
fx: tests
whatphilipcodes Sep 30, 2024
2ed6788
fx: formatting
whatphilipcodes Sep 30, 2024
a851550
add: change log
whatphilipcodes Sep 30, 2024
6b348fd
fx: formatting
whatphilipcodes Sep 30, 2024
25218c1
add missing dep 'requests'
Sep 18, 2024
320cdbe
handle empty album str
Sep 20, 2024
25e4365
build: use standard poetry workflow
snejus Sep 30, 2024
740d6e0
add: change log
whatphilipcodes Sep 30, 2024
0196a46
fx: porb
whatphilipcodes Sep 30, 2024
4a4524f
Merge branch 'main' into fx-exclude-fields
whatphilipcodes Sep 30, 2024
2d699fc
Revert "Merge pull request #1 from whatphilipcodes/fx-autotagger-query"
whatphilipcodes Oct 1, 2024
2e8166f
fx: breaking change from beets v1.6.1
whatphilipcodes Oct 1, 2024
060ea97
Lock only beets dependency
whatphilipcodes Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions beetsplug/bandcamp/metaguru.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def from_html(cls, html: str, config: Optional[JSONDict] = None) -> "Metaguru":

@cached_property
def excluded_fields(self) -> Set[str]:
return set(self.config.get("excluded_fields") or [])
return set(self.config.get("exclude_extra_fields") or [])
snejus marked this conversation as resolved.
Show resolved Hide resolved

@property
def comments(self) -> Optional[str]:
Expand All @@ -95,10 +95,12 @@ def comments(self) -> Optional[str]:

@cached_property
def all_media_comments(self) -> str:
return "\n".join([
*[m.description for m in self.media_formats],
self.comments or "",
])
return "\n".join(
whatphilipcodes marked this conversation as resolved.
Show resolved Hide resolved
[
*[m.description for m in self.media_formats],
self.comments or "",
]
)

@cached_property
def label(self) -> str:
Expand Down
Loading