Fix parsing URLs from item comments, add -p / --page flag to cmdline #57
Conversation
Pull Request Test Coverage Report for Build 8985172684Details
💛 - Coveralls |
snejus
force-pushed
the
fix-parsing-url-from-comments
branch
from
b8ad375
to
02319da
Compare
| [ | ||
| ("Visit https://label.bandcamp.com", "https://label.bandcamp.com"), | ||
| ("Visit https://supercommuter.net", "https://supercommuter.net"), | ||
| ("Visit https://no-top-level-domain", None), |
There was a problem hiding this comment.
Hey, sorry I'm a little late to this, but is it worth adding a test case for a URL with more than two domain parts, e.g. a sub-domain of a country TLD like https://myband.com.au/ or https://myband.co.uk/? I'm not sure if your regular expression handles more than one dot in the domain portion.
There was a problem hiding this comment.
To be honest I did not even give a chance for anyone to have a look at this 😅
This is a good idea, of course! Would you like to contribute yourself by any chance?
There was a problem hiding this comment.
I'll see if I can find time over the next couple days. Otherwise, feel free to give it a go yourself.
There was a problem hiding this comment.
Also, I am in Australia, so I think we're battling timezones a little. 😅
There was a problem hiding this comment.
I checked the URLs that you provided and it seems to handle them well, but I'm excited to see whether you could find a URL that breaks it!
Fixed
Added
[-p PAGE, --page PAGE]to enable seeing further search results