Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7, fix genre shenanigans, parse 'with' and 'w/' #55

Merged
merged 40 commits into from
Apr 28, 2024
Merged

Conversation

snejus
Copy link
Owner

@snejus snejus commented Apr 28, 2024

Removed

  • Dropped support for python 3.7.

Fixed

Updated

  • album:

    • handle some edge cases when string EP or LP is followed with data relevant to the album
    • do not remove artist or label when it is preceded by x or followed by characters ', _ and &, or words EP, LP and deluxe
    • handle apostrophes more reliably
    • Do not remove VA or V/A from the beginning when followed by a word or a number
  • album / title:

  • catalognum:

    • allow catalogue numbers like Dystopian LP01
    • parse a range of catalogue numbers when it is present, for example TFT013SR - TFT-016SR
  • comments: use value None when there are no comments. In contrast to returning an empty string, this way during beets import the previous comment on the track will be kept if the Bandcamp release does not have a description.

  • label: label is now correctly obtained for single releases when it is available.

  • title:

    • consider with and w/ as markers for collaborating artists
    • remove bonus - - Artist - Title (bonus - something) -> Artist - Title (something)

@snejus snejus self-assigned this Apr 28, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8868630102

Details

  • 340 of 353 (96.32%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.7%) to 90.85%

Changes Missing Coverage Covered Lines Changed/Added Lines %
beetsplug/bandcamp/album.py 52 54 96.3%
beetsplug/bandcamp/track_names.py 81 83 97.59%
beetsplug/bandcamp/tracks.py 69 71 97.18%
beetsplug/bandcamp/init.py 42 45 93.33%
beetsplug/bandcamp/helpers.py 18 22 81.82%
Totals Coverage Status
Change from base Build 5807104016: 2.7%
Covered Lines: 1012
Relevant Lines: 1111

💛 - Coveralls

@snejus snejus merged commit d4f9835 into main Apr 28, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants