Resolve clippy issues #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves clippy warnings like this:
```
error: needless call to `as_bytes()`
--> src/protocol/frame/frame.rs:346:44
|
346 | let mut p = Vec::with_capacity(reason.as_bytes().len() + 2);
| ^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `reason.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
= note: `-D clippy::needless-as-bytes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_as_bytes)]`
```
This solves clippy warnings like this:
```
error: the following explicit lifetimes could be elided: 't
--> src/protocol/frame/frame.rs:35:6
|
35 | impl<'t> fmt::Display for CloseFrame<'t> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
35 - impl<'t> fmt::Display for CloseFrame<'t> {
35 + impl fmt::Display for CloseFrame<'_> {
|
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest stable clippy has new lints. In two commits, I solved the new lints.
I suggest using a fixed clippy version to prevent future breakage. If you are interested, I could do that in a separate PR.