Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Conversation

@Sekhmet
Copy link
Member

@Sekhmet Sekhmet commented Oct 9, 2022

Closes: #315

Screenshots

image

@Sekhmet Sekhmet requested a review from bonustrack October 9, 2022 22:07
@Sekhmet Sekhmet self-assigned this Oct 9, 2022
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We may want to also truncate the NFT name in the selector to get consistent item height
image

@Sekhmet Sekhmet requested a review from bonustrack October 10, 2022 09:11
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

const size = props.size ? props.size * 2 : 256;
const fallbackUrl = computed(
() =>
`https://cdn.stamp.fyi/token/${props.item.contractAddress}?s=${
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the Stamp NFT endpoint in future to avoid fallback

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR wasn't merged yet:
snapshot-labs/stamp#28

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I'll make review there

@Sekhmet Sekhmet merged commit c9f6936 into master Oct 10, 2022
@Sekhmet Sekhmet deleted the sekhmet/opensea-nfts branch October 10, 2022 13:02
Sekhmet added a commit to snapshot-labs/sx-monorepo that referenced this pull request Feb 6, 2024
* feat: use OpenSea for fetching NFTs

* feat: truncate long NFT names

* test: update tests

* feat: force same aspect for all NFTs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to OpenSea API to query NFTs

3 participants