chore: optimize Tailwind CSS classes

[wa0x6e]

Summary

Fix and cleanup css, in anticipation of adding eslint rules for scss.

Those are just regular and simple fixes, without any controversial rules

• Remove invalid button-outline classes, ported from snapshot v1
• Remove invalid text-color
• Use shorthand classes when possible (w-[] z-[] to size-[])
• Use tailwindcss own size class instead of arbitrary px values (s-[4px] to s-1)
• Arbitrary classes should not start by -, use negative value instead (-mb-[5px] will become mb-[-5px])
• Replace invalid class by their nearest valid equivalent (flex-grow -> grow, z-5 -> z-10, etc ...)
• Remove conflicting class (flex and box simultaneous usage)

Todo in a later pr will be more heavy changes, like css classes ordering

[Sekhmet]

nACK

Let's discuss each change first and submit smaller PRs for different changes.

As of now I think those points can have been submitted already:

• Remove conflicting class (flex and box simultaneous usage)
• Use shorthand classes when possible (w-[] z-[] to size-[])
• Replace invalid text-color class by text-skin-text
• Remove invalid button-outline classes, ported from snapshot v1
• Arbitrary classes should not start by -, use negative value instead (-mb-[5px] will become mb-[-5px])

Ideally those should be separated into each own PR so we can easily review it and test it doesn't break anything.

The rest should be discussed first.

[wa0x6e]

nACK

Let's discuss each change first and submit smaller PRs for different changes.

As of now I think those points can have been submitted already:

• Remove conflicting class (flex and box simultaneous usage)
• Use shorthand classes when possible (w-[] z-[] to size-[])
• Replace invalid text-color class by text-skin-text
• Remove invalid button-outline classes, ported from snapshot v1
• Arbitrary classes should not start by -, use negative value instead (-mb-[5px] will become mb-[-5px])

Ideally those should be separated into each own PR so we can easily review it and test it doesn't break anything.

The rest should be discussed first.

Updated to revert all changes requiring any discussions.

This PR was meant to be a no-brainer changes, and should include only obvious fixes which does not require any testing

[Sekhmet]

For text-color -> text-skin-text changes - as text-color wasn't doing anything before shouldn't we just remove this property entirely? Now we either add property that doesn't change anything or we change colour making it break old behaviour.
In this case it looks like we just add property that doesn't actually do anything.

[wa0x6e]

For text-color -> text-skin-text changes - as text-color wasn't doing anything before shouldn't we just remove this property entirely? Now we either add property that doesn't change anything or we change colour making it break old behaviour. In this case it looks like we just add property that doesn't actually do anything.

removed

[Sekhmet]

Not sure why h-2 was changed to h-[8px].

[wa0x6e]

For consistency, everything that is not spacing related ((m|p|space|gap)-[0-9]) is using arbitrary pixels value.

we're already using h-[32px] for avatar, etc ...

Or should we keep using both h-2 and h-[8px] ?

[Sekhmet]

I see, let's keep it like this then.

[Sekhmet]

tACK

[Sekhmet]

@wa0x6e merge conflict needs to be resolved.