-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't show empty placeholder account in the account button #538
Conversation
btw, We don't handle this case on snapshot.org, the connect button just crash, and don't appear anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
Do we need another loading state? We already have one loading state (just loading indicator), now we are adding another different state which to me means the same. Is it related to this PR? #220 I feel like situation where |
This is continuation of fixing of #220 indeed. In the previous PR, we fixed the error occuring after the page refresh step. This PR is quickfix, the best way to fix this would be trigger the metamask prompt again when you want to connect to metamask. Seems it's an open issue for years MetaMask/metamask-extension#10085 There's some kind of solution proposed there, will try a few |
Will instead be fixed in amount, with snapshot-labs/lock#114 This will fix the issue where an authenticated user is not authenticated |
This issue has been resolved with new version of lock: snapshot-labs/lock@b5a3203 @Sekhmet how are packages updated ? |
@wa0x6e it looks like 0.2.5 was published via CI after your PR was merged. So here you just bump package to the version you need and run |
Summary
This fix an issue when metamask is locked, and logged out user is not accepting to unlock it when prompted
Issue reproduction
This PR will try to fix this issue by showing a special state for when metamask is waiting for an user action, by showing the "Waiting for your wallet" message (can be improved)
How to test
0x000
icon and empty account name, it should show the "Waiting for your wallet" messageNote