feat: add reason when voting

.changeset/breezy-owls-clean.md

@@ -0,0 +1,5 @@
+---
+"@snapshot-labs/sx": patch
+---
+
+support submitting a reason when voting

apps/ui/src/components/IndicatorVotingPower.vue

@@ -1,40 +1,29 @@
 <script setup lang="ts">
-import { _vp } from '@/helpers/utils';
+import { getFormattedVotingPower } from '@/helpers/utils';
 import { evmNetworks } from '@/networks';
-import { VotingPower, VotingPowerStatus } from '@/networks/types';
+import { VotingPowerItem } from '@/stores/votingPowers';
 import { NetworkID } from '@/types';
 
 const props = defineProps<{
   networkId: NetworkID;
-  status: VotingPowerStatus;
-  votingPowerSymbol: string;
-  votingPowers: VotingPower[];
+  votingPower?: VotingPowerItem;
 }>();
 
 defineEmits<{
-  (e: 'getVotingPower');
+  (e: 'fetchVotingPower');
 }>();
 
 const { web3 } = useWeb3();
 
 const modalOpen = ref(false);
 
-const votingPower = computed(() =>
-  props.votingPowers.reduce((acc, b) => acc + b.value, 0n)
+const formattedVotingPower = computed(() =>
+  getFormattedVotingPower(props.votingPower)
 );
-const decimals = computed(() =>
-  Math.max(...props.votingPowers.map(votingPower => votingPower.decimals), 0)
-);
-const formattedVotingPower = computed(() => {
-  const value = _vp(Number(votingPower.value) / 10 ** decimals.value);
-
-  if (props.votingPowerSymbol) {
-    return `${value} ${props.votingPowerSymbol}`;
-  }
 
-  return value;
-});
-const loading = computed(() => props.status === 'loading');
+const loading = computed(
+  () => !props.votingPower || props.votingPower.status === 'loading'
+);
 
 function handleModalOpen() {
   modalOpen.value = true;
@@ -63,7 +52,7 @@ function handleModalOpen() {
         >
           <IH-lightning-bolt class="inline-block -ml-1" />
           <IH-exclamation
-            v-if="props.status === 'error'"
+            v-if="props.votingPower?.status === 'error'"
             class="inline-block ml-1 text-rose-500"
           />
           <span v-else class="ml-1">{{ formattedVotingPower }}</span>
@@ -74,12 +63,9 @@ function handleModalOpen() {
       <ModalVotingPower
         :open="modalOpen"
         :network-id="networkId"
-        :voting-power-symbol="votingPowerSymbol"
-        :voting-powers="props.votingPowers"
-        :voting-power-status="status"
-        :final-decimals="decimals"
+        :voting-power="props.votingPower"
         @close="modalOpen = false"
-        @get-voting-power="$emit('getVotingPower')"
+        @fetch-voting-power="$emit('fetchVotingPower')"
       />
     </teleport>
   </div>

apps/ui/src/components/MessageVotingPower.vue

@@ -0,0 +1,52 @@
+<script setup lang="ts">
+import { VotingPowerItem } from '@/stores/votingPowers';
+
+const props = defineProps<{
+  minVotingPower?: bigint;
+  minProposalThreshold?: bigint;
+  votingPower: VotingPowerItem;
+}>();
+
+defineEmits<{
+  (e: 'fetchVotingPower');
+}>();
+
+const insufficientVoteVp = computed(
+  () =>
+    props.votingPower.status === 'success' &&
+    props.minVotingPower !== undefined &&
+    props.votingPower.totalVotingPower <= props.minVotingPower
+);
+
+const insufficientProposeVp = computed(
+  () =>
+    props.votingPower.status === 'success' &&
+    props.minProposalThreshold !== undefined &&
+    props.votingPower.totalVotingPower < props.minProposalThreshold
+);
+</script>
+
+<template>
+  <div
+    v-if="votingPower.status === 'error'"
+    class="flex flex-col gap-3 items-start"
+    v-bind="$attrs"
+  >
+    <UiAlert type="error">
+      There was an error fetching your voting power.
+    </UiAlert>
+    <UiButton
+      type="button"
+      class="flex items-center gap-2"
+      @click="$emit('fetchVotingPower')"
+    >
+      <IH-refresh />Retry
+    </UiButton>
+  </div>
+  <UiAlert v-else-if="insufficientVoteVp" type="error">
+    You do not have enough voting power to vote.
+  </UiAlert>
+  <UiAlert v-else-if="insufficientProposeVp" type="error">
+    You do not have enough voting power to create proposal in this space.
+  </UiAlert>
+</template>

apps/ui/src/components/Modal/Vote.vue

@@ -0,0 +1,148 @@
+<script setup lang="ts">
+import { getChoiceText, getFormattedVotingPower } from '@/helpers/utils';
+import { validateForm } from '@/helpers/validation';
+import { Choice, Proposal } from '@/types';
+
+const definition = {
+  type: 'object',
+  title: 'Vote',
+  additionalProperties: false,
+  required: [],
+  properties: {
+    reason: {
+      title: 'Reason',
+      type: 'string',
+      format: 'long',
+      examples: ['Share you reason (optional)'],
+      maxLength: 1000
+    }
+  }
+};
+
+const props = defineProps<{
+  proposal: Proposal;
+  choice: Choice | null;
+  open: boolean;
+}>();
+
+const emit = defineEmits<{
+  (e: 'close');
+  (e: 'voted');
+}>();
+
+const { vote } = useActions();
+const { web3 } = useWeb3();
+const {
+  votingPower,
+  fetch: fetchVotingPower,
+  reset: resetVotingPower,
+  hasVoteVp
+} = useVotingPower();
+
+const loading = ref(false);
+const form = ref<Record<string, string>>({ reason: '' });
+
+const formErrors = computed(() =>
+  validateForm(definition, form.value, { skipEmptyOptionalFields: true })
+);
+const formattedVotingPower = computed(() =>
+  getFormattedVotingPower(votingPower.value)
+);
+
+const canSubmit = computed(
+  () =>
+    !!props.choice &&
+    Object.keys(formErrors.value).length === 0 &&
+    hasVoteVp.value
+);
+
+async function handleSubmit() {
+  loading.value = true;
+
+  if (!props.choice) return;
+
+  try {
+    await vote(props.proposal, props.choice, form.value.reason);
+    emit('voted');
+    emit('close');
+  } finally {
+    loading.value = false;
+  }
+}
+
+function handleFetchVotingPower() {
+  fetchVotingPower(props.proposal);
+}
+
+watch(
+  [() => props.open, () => web3.value.account],
+  ([open, toAccount], [, fromAccount]) => {
+    if (fromAccount && toAccount && fromAccount !== toAccount) {
+      resetVotingPower();
+    }
+
+    if (open) handleFetchVotingPower();
+  },
+  { immediate: true }
+);
+</script>
+
+<template>
+  <UiModal :open="open" @close="$emit('close')">
+    <template #header>
+      <h3>Cast your vote</h3>
+    </template>
+
+    <div class="m-4 flex flex-col space-y-3">
+      <MessageVotingPower
+        v-if="votingPower"
+        :voting-power="votingPower"
+        :min-voting-power="0n"
+        @fetch-voting-power="handleFetchVotingPower"
+      />
+      <dl>
+        <dt class="text-sm leading-5">Choice</dt>
+        <dd class="font-semibold text-skin-heading text-[20px] leading-6">
+          <span
+            v-if="choice"
+            class="test-skin-heading"
+            v-text="getChoiceText(proposal.choices, choice)"
+          />
+          <span v-else class="text-skin-danger"> No choice selected </span>
+        </dd>
+        <dt class="text-sm leading-5 mt-3">Voting power</dt>
+        <dd v-if="!votingPower || votingPower.status === 'loading'">
+          <UiLoading />
+        </dd>
+        <dd
+          v-else-if="votingPower.status === 'success'"
+          class="font-semibold text-skin-heading text-[20px] leading-6"
+          v-text="formattedVotingPower"
+        />
+        <dd
+          v-else-if="votingPower.status === 'error'"
+          class="font-semibold text-skin-heading text-[20px] leading-6"
+          v-text="formattedVotingPower"
+        />
+      </dl>
+      <div class="s-box">
+        <UiForm v-model="form" :error="formErrors" :definition="definition" />
+      </div>
+    </div>
+
+    <template #footer>
+      <div class="flex space-x-3">
+        <UiButton class="w-full" @click="$emit('close')"> Cancel </UiButton>
+        <UiButton
+          primary
+          class="w-full"
+          :disabled="!canSubmit"
+          :loading="loading"
+          @click="handleSubmit"
+        >
+          Confirm
+        </UiButton>
+      </div>
+    </template>
+  </UiModal>
+</template>

apps/ui/src/components/Modal/VotingPower.vue

@@ -2,21 +2,18 @@
 import { _n, shorten } from '@/helpers/utils';
 import { addressValidator as isValidAddress } from '@/helpers/validation';
 import { getNetwork } from '@/networks';
-import { VotingPower, VotingPowerStatus } from '@/networks/types';
+import { VotingPowerItem } from '@/stores/votingPowers';
 import { NetworkID } from '@/types';
 
 const props = defineProps<{
   open: boolean;
   networkId: NetworkID;
-  votingPowerSymbol: string;
-  votingPowers: VotingPower[];
-  votingPowerStatus: VotingPowerStatus;
-  finalDecimals: number;
+  votingPower?: VotingPowerItem;
 }>();
 
 defineEmits<{
   (e: 'close');
-  (e: 'getVotingPower');
+  (e: 'fetchVotingPower');
 }>();
 
 const network = computed(() => getNetwork(props.networkId));
@@ -25,8 +22,9 @@ const baseNetwork = computed(() =>
     ? getNetwork(network.value.baseNetworkId)
     : network.value
 );
-const loading = computed(() => props.votingPowerStatus === 'loading');
-const error = computed(() => props.votingPowerStatus === 'error');
+const loading = computed(
+  () => !props.votingPower || props.votingPower.status === 'loading'
+);
 </script>
 
 <template>
@@ -35,21 +33,14 @@ const error = computed(() => props.votingPowerStatus === 'error');
       <h3>Your voting power</h3>
     </template>
     <UiLoading v-if="loading" class="p-4 block text-center" />
-    <div v-else>
-      <div v-if="error" class="p-4 flex flex-col gap-3 items-start">
-        <UiAlert type="error"
-          >There was an error fetching your voting power.</UiAlert
-        >
-        <UiButton
-          type="button"
-          class="flex items-center gap-2"
-          @click="$emit('getVotingPower')"
-        >
-          <IH-refresh />Retry
-        </UiButton>
-      </div>
+    <div v-else-if="votingPower">
+      <MessageVotingPower
+        class="p-4"
+        :voting-power="votingPower"
+        @fetch-voting-power="$emit('fetchVotingPower')"
+      />
       <div
-        v-for="(strategy, i) in votingPowers"
+        v-for="(strategy, i) in votingPower.votingPowers"
         :key="i"
         class="py-3 px-4 border-b last:border-b-0"
       >
@@ -67,12 +58,16 @@ const error = computed(() => props.votingPowerStatus === 'error');
           />
           <div class="text-skin-link shrink-0">
             {{
-              _n(Number(strategy.value) / 10 ** finalDecimals, 'compact', {
-                maximumFractionDigits: 2,
-                formatDust: true
-              })
+              _n(
+                Number(strategy.value) / 10 ** votingPower.decimals,
+                'compact',
+                {
+                  maximumFractionDigits: 2,
+                  formatDust: true
+                }
+              )
             }}
-            {{ votingPowerSymbol }}
+            {{ votingPower.symbol }}
           </div>
         </div>
         <div class="flex justify-between">

apps/ui/src/components/ProposalVoteApproval.vue

@@ -4,7 +4,6 @@ import { Choice, Proposal } from '@/types';
 type ApprovalChoice = number[];
 
 const props = defineProps<{
-  sendingType: Choice | null;
   proposal: Proposal;
   defaultChoice?: Choice;
 }>();
@@ -45,7 +44,6 @@ function toggleSelectedChoice(choice: number) {
     <UiButton
       primary
       class="!h-[48px] w-full"
-      :loading="!!sendingType"
       @click="emit('vote', selectedChoices)"
     >
       Vote