fix: fix empty voting period being overriden

[wa0x6e]

Summary

Closes: #1012
Toward https://github.com/snapshot-labs/workflow/issues/282

This PR fix an issue where the voting period is saved as empty for offchain spaces, but shows as 7 days on the UI.

Issue was fixed by allowing 0 as voting period value (which means no default enforcing, and up to the proposer), with a fallback to 3 days (like on v1)

How to test

1. Go to an offchain space settings
2. Save the voting period as 0
3. It saves as 0 (previously, will always show 7 instead of 0)
4. Go to the Editor
5. Proposal end time should be set to 3 days after start

[Sekhmet]

Needs rebase now to account for created param.

[wa0x6e]

With this fix, we got a minor behavior change:

The proposal created and start date are now set on Editor page load, and not on on form submit.

As filling the form may take time, the creation and start date may be a few minutes behind now (which is still valid, and accepted by sequencer).

On the opposite, the dates shown on the Editor timeline are now the correct dates sent to the proposal.

EDIT: not the case anymore

[Sekhmet]

With this fix, we got a minor behavior change

To me it's not expected behavior, why does it work this way?

Can we instead, same as before submit timestamp at the time of submit and for Editor UI make timeline reactive and update it on the fly using useNow or something similar? Or is it not possible for some reason?

[wa0x6e]

With this fix, we got a minor behavior change

To me it's not expected behavior, why does it work this way?

Can we instead, same as before submit timestamp at the time of submit and for Editor UI make timeline reactive and update it on the fly using useNow or something similar? Or is it not possible for some reason?

Implemented using reactive timestamp.