refactor: move the proposal start and end time to Editor #1013
+28
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' of https://github.com/snapshot-labs/sx-monorepo into refactor-move-proposal-start-end-time-setting-to-editor
Sekhmet
reviewed
Dec 3, 2024
wa0x6e
force-pushed
the
refactor-move-proposal-start-end-time-setting-to-editor
branch
from
a4666bb
to
251873f
Compare
wa0x6e
deleted the
refactor-move-proposal-start-end-time-setting-to-editor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Toward https://github.com/snapshot-labs/workflow/issues/282
This PR refactors where the proposal start/end time is being set.
Previously, this was set in networks/offchain/action.ts, since the start and end time are set at the space level.
With the upcoming feature, these values will be editable by the proposer, and should be set via the Editor.
How to test