Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: offchain space voting period default to 7 days when null #1012

Closed
wa0x6e opened this issue Dec 2, 2024 · 0 comments · Fixed by #1014
Closed

bug: offchain space voting period default to 7 days when null #1012

wa0x6e opened this issue Dec 2, 2024 · 0 comments · Fixed by #1014
Assignees

Comments

@wa0x6e
Copy link
Contributor

wa0x6e commented Dec 2, 2024

Voting period for offchain spaces settings is being forced to default to 7 days when 0, since we do not allow period customization on the proposal level.

This create confusion, since we can save the period as 0, but will show 7 on the UI.

Working toward https://github.com/snapshot-labs/workflow/issues/282 , we should remove the forced default value, and allow empty voting period on offchain spaces.

@wa0x6e wa0x6e changed the title bug: space voting period can not be saved to 0 feat: allow offchain space voting period to be null Dec 3, 2024
@wa0x6e wa0x6e changed the title feat: allow offchain space voting period to be null bug: offchain space voting period default to 7 days when null Dec 3, 2024
@wa0x6e wa0x6e self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant