feat: add domain api to return custom domain associated to an offchain space #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaituVR
approved these changes
Sep 12, 2024
|
|
||
| const body: Record<string, string> = await response.json(); | ||
|
|
||
| data = new Map(Object.entries(body).map(([domain, spaceId]) => [domain, `s:${spaceId}`])); |
There was a problem hiding this comment.
Do we want to store sx spaces on snapshot-spaces?
then maybe it is better to add s: on that repo
There was a problem hiding this comment.
I think this repo will be deprecated soon.
Sidekick is aggregating v2 spaces from the repo, sx spaces will have another source I believe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards https://github.com/snapshot-labs/workflow/issues/142
See also https://discord.com/channels/955773041898573854/1282876175642918964/1283367668648382587
This PR will add a new
/api/domainendpoint to return a custom domain associated to an offchain space.Domains list will be pulled from the snapshot-spaces repo, be cached in memory, and refreshed every 5 minutes.
Test
yarn devcurl http://localhost:3005/api/domains/vote.lends.so{"domain":"vote.lends.so","space_id":"s:lendsdao.eth"}curl http://localhost:3005/api/domains/random{"domain":"vote.lends.so","space_id":null}