Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update metrics dependency to last version #170

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Sep 11, 2023

Changes

  • Update snapshot-sentry to latest version (add support to capture JSON-RPC error)
  • Update snapshot-metrics to latest version (add pushgateway support)

@wa0x6e wa0x6e requested a review from Todmy September 11, 2023 09:59
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (417f011) 55.41% compared to head (bdaf09b) 55.37%.
Report is 1 commits behind head on main.

❗ Current head bdaf09b differs from pull request most recent head c7d9ff9. Consider uploading reports for the commit c7d9ff9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   55.41%   55.37%   -0.04%     
==========================================
  Files          19       19              
  Lines        1570     1571       +1     
  Branches      111      111              
==========================================
  Hits          870      870              
- Misses        691      692       +1     
  Partials        9        9              
Files Changed Coverage Δ
src/lib/metrics/index.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/lib/metrics/index.ts Outdated Show resolved Hide resolved
@wa0x6e wa0x6e requested a review from Todmy September 12, 2023 11:28
Copy link
Contributor

@Todmy Todmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@wa0x6e wa0x6e merged commit 56933e5 into main Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants