Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧿 Current issues / What's wrong ?
There's a lot of recurring connections to the same services, at a high rate.
Opening a new connection on each request is costly, and create overhead, particularly on frequently requested url
💊 Fixes / Solution
We should reuse the connection when possible, by using a keep alive connection.
Fix #167
Fix #168
Fix SNAPSHOT-SIDEKICK-2
Fix SNAPSHOT-SIDEKICK-E
🚧 Changes
node-fetch
instead ofcross-fetch
(don't need browser support)node-fetch
, injecting keep-alive connection by using a custom agent.fetch
function whenever possible🛠️ Tests
yarn test:integration
curl -X POST localhost:3005/api/votes/0xa34107e34b4dc4ff4cd16b77d66e62a51f4d35457a4f4b1f68ab8ac821f58561